Optional type-only matching for meta-less pipe filters - #1384
Open
RasmusKD wants to merge 1 commit into
Open
Conversation
The filter comparison rejects any item whose meta differs from the filter entry, so a plain 'potion' filter never catches brewed potions, and enchanted books and renamed items slip past every plain filter into overflow. Filtering on exact meta instead means spelling out every enchant and potion variant on a sign, which is not practical. With 'filters-match-type' enabled, a filter entry that carries no item meta matches on type alone, so every variant of an item sorts into that item's chest. Filter entries that do specify meta still compare it exactly. Off by default, which keeps the strict comparison unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from our chat, so you can see the actual change and decide.
The filter comparison rejects any item whose meta differs from the filter entry, so a plain 'potion' filter never catches brewed potions, and enchanted books and renamed items slip past every plain filter into overflow. Filtering on exact meta instead means spelling out every enchant and potion variant on a sign, which is not practical.
With 'filters-match-type' enabled, a filter entry that carries no item meta matches on type alone, so every variant of a diamond helmet sorts into the diamond helmet chest and all potions into the potion chest. Filter entries that do specify meta still compare it exactly. Off by default: the strict comparison is byte-for-byte unchanged unless a server opts in.
Fine to close if you'd rather leave filtering alone.